[PATCH][libstdc++-v3 parallel mode] Tackle further XXX todos

Johannes Singler singler@ira.uka.de
Tue Sep 29 09:08:00 GMT 2009


Benjamin Kosnik wrote:
>> Unfortunately, this isn't ok, until c/448 will be finally closed: you
>> can't assume stdint.h facilities (thus  tr1/cstdint facilities) to be
>> available everywhere.
> 
> ... parallel mode is already limited to underlying platforms that:
> 
> 1) have atomic ops
> 2) have open mp
> 
> requiring stdint.h in addition will likely cause no loss of existing
> platform coverage IMHO (as per
> http://gcc.gnu.org/ml/gcc/2009-07/msg00625.html). It would be my strong
> preference to remove duplication and not invent new types in parallel
> mode, and instead use stdint.h. Of course, documenting this new
> dependency here:
> 
> http://gcc.gnu.org/onlinedocs/libstdc++/manual/bk01pt12ch31s03.html
> 
> seems like a good idea.

2009-09-29  Johannes Singler  <singler@ira.uka.de>

        * include/parallel/base.h: Take integer types from
        <tr1/cstdint>.
        * include/parallel/compatibility.h: Likewise.
        * include/parallel/multiseq_selection.h: Likewise.
        * include/parallel/random_shuffle.h: Likewise.
        * include/parallel/random_number.h: Likewise;
        use numeric_limits<>::digit instead of sizeof()*8.
        * include/parallel/types.h: Likewise.
        * doc/html/manual/bk01pt12ch31s03.html:
        Document dependency on stdint.h.

I added a one-line comment to that file.  Patch okay for commit now?

-- Johannes

-------------- next part --------------
A non-text attachment was scrubbed...
Name: stdint_types.patch
Type: text/x-patch
Size: 15472 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20090929/af6e4498/attachment.bin>


More information about the Libstdc++ mailing list