[PATCH][libstdc++-v3 parallel mode] Tackle XXX todos: move compare to last place
Benjamin Kosnik
bkoz@redhat.com
Thu Sep 24 03:05:00 GMT 2009
> This patch fixes a small todo, and removes another (cannot remove
> duplicates of std:: functors because they have different structure).
What about __gnu_parallel::max and __gnu_parallel::min?
> 2009-09-23 Johannes Singler <singler@ira.uka.de>
>
> * include/parallel/algobase.h
> (__lexicographical_compare_switch): Move compare template
> parameter to the end as of others.
This part is ok, thanks.
> include/parallel/checkers.h: // XXX Compare default template argument
I was wondering about the form here of these sorting functions. Is
there a simpler way to arrange this? Usage is such that all known call
sites include all three arguments. (No default argument is used.)
Compare passed by value...
?
> include/parallel/for_each_selectors.h: // XXX move into type_traits?
_Nothing to __accumulate_binop_reduct seem to be utility bits,
unrelated to the rest of the file. Should they be moved elsewhere?
> include/parallel/partition.h: // XXX _Compare must have
> first__ValueType, second__ValueType,
> include/parallel/partition.h: // XXX binder2nd only for
> _RAIters??
Sadly, I can't remember this one. I think this is about type
constraints on binder2nd, or questions on the way it's instantiated.
best
-benjamin
More information about the Libstdc++
mailing list