_GLIBCXX_ASSERT lossage

[Pétur Runólfsson]

Paolo Carlini wrote:
> > ... but, AFAICT, *all* the testcases are built passing explicitly
> > -D_GLIBCXX_ASSERT on the command line...
> 
> Ah! Now I see, sorry! For some reason -D_GLIBCXX_ASSERT is *not* passed
> for those new tests!

Yes, using dg-options means -D_GLIBCXX_ASSERT will not be used, unless
it's done manually, as in testsuite/backward/11460.cc:
// { dg-options "-Wno-deprecated -D_GLIBCXX_ASSERT" }

> So, for all practical matters, they are just disabled! Grrrrrrr....

Yes. This is documented in testsuite/libstdc++-dg/normal.exp:

# If a libstdc++ test file doesn't have special options, use DEFAULT_CXXFLAGS.
# Use this variable if the behavior
# 1) only applies to libstdc++ testing
# 2) might need to be negated 
# In particular, some tests have to be run without precompiled
# headers, or without assertions.

However, I haven't seen any test case that uses VERIFY, but requires
that _GLIBCXX_ASSERT should not be defined (I may have missed some
though) so this seems pretty bogus.

Petur