RFC Fix for 9964.cc and 9507.cc on ia64-hpux

[Paolo Carlini]

Zack Weinberg wrote:

>>> Unfortunately, this
>>> constitutes an ABI change since _M_open_mode was exported.
>>
>> There are lots of ABI changes between 3.3 and 3.4, including changes
>> to __basic_file.
>
> So in 3.4 I can just make _M_open_mode completely go away? Cool.
> How about 3.3?

Most probably, if, as Pétur says, _M_open_mode was exported, you can't
for 3.3.

By the way, as far as this simple kind of ABI changes are concerned
(having to do with exported symbols), usually 'make check-abi' is quite
reliable.

>>> +static const char *fopen_mode(std::ios_base::openmode mode)
>>
>> This should probably be uglified and formatted as:
>> static const char*
>> __fopen_mode(std::ios_base::openmode __mode)
>
> Why? It's static and it's not in any kind of header file.

Gaby/Nathan are much better than me at this kind of issue, but, basing
on the past history, I tend to believe that uglifying the thing is the
easiest way to have the patch accepted gracefully without having to use
your superpowers of Write Blanket Privileges ;)

Paolo.