[PATCH] Enable input using variable-width encodings

Benjamin Kosnik bkoz@redhat.com
Fri Sep 5 13:38:00 GMT 2003


>Thanks!

No, thank you...

>> I'm wondering a
>> bit about using a signed type for _M_ext_buf_size when _M_buf_size is
>> signed,
>
>Did you mean unsigned?

Right, sorry for the confusion.

>> but am not too worried about it.
>
>That is to allow the comparisons:
>! 	      if (_M_ext_buf_size < __blen)
>and
>! 		      if (_M_ext_end - _M_ext_buf + __rlen > _M_ext_buf_size)
>without extra casts. These are the only places that
>_M_ext_buf_size is used.

Right. I saw that.

>I agree that the current mix of size_t and streamsize in the 
>iostreams code is somewhat confusing. Maybe streamsize should
>be used everywhere? (Some places need signed values, so
>size_t wouldn't do.)

Yeah, that's what I am thinking too.

-benjamin



More information about the Libstdc++ mailing list