Benjamin Kosnik wrote: >Looks fine, you might use __tmp like the rest of the local variables, >and move it below the comment. > Agreed! This is of more value now that I have learned that my improvement for str() was not really 100% safe due to the COW nature of our basic_string... Paolo.