PATCH - Re: Troubles with current 3.3 and 21_strings/ctor_copy_dtor.cc

Paolo Carlini pcarlini@unitus.it
Thu Jul 17 17:25:00 GMT 2003


Phil Edwards wrote:

>The mainline change was originally made for reasons of clarity:  it's a
>boolean test, the result should eitehr be true or false, and writing it
>that way makes it easier to read.  It also makes it easier to test, since
>"true" and "false" are *nix commands which can be done directly.
>
>We're not doing the latter on the 3.3 branch.  (On the trunk, it's tied in
>with other changes.)  And that's the reason it makes a difference on 3.3:
>it's doing a textual comparison instead of a "meaning" comparison:
>
Ah!

>   AC_DEFUN(GLIBCPP_CONFIGURE_TESTSUITE, [
>     if test  x"$GLIBCPP_IS_CROSS_COMPILING" = xfalse; then
>       # Do checks for memory limit functions.
>       GLIBCPP_CHECK_SETRLIMIT
>   ....
>
>So yes, this patch needs to go in.  I'm wrestling with Solaris at the
>moment, could you do the regeneration and commit?
>
Sure, Phil, thanks for your prompt feedback!

Only configure needs to be regenerated in this case, right?

(please excuse my naivete with the autoconf machinery: sometime I still 
get lost in the tangle aclocal-autoconf-autoheader-automake :(

Paolo.



More information about the Libstdc++ mailing list