[PATCH] _M_replace (take3): better clean up + speed ups!!

[Paolo Carlini]

Phil Edwards wrote:

> I'll leave commenting on this patch to others (I am not as familiar with
> string), but I'll mention this purely as a matter of form:
>
> >         * include/bits/basic_string.tcc (_M_replace_safe): New.
> >         * include/bits/basic_string.tcc (_M_replace(input_iterator_tag),
> >         append members): use it.
> >         * include/bits/basic_string.tcc (_M_replace(forward_iterator_tag)): Remove.
> >         * include/bits/basic_string.h: Adjust declarations.
> >         * src/string-inst.cc: Adjust declarations.
>
> Files are usually listed multiple times only when there are unreleated
> changes; for this patch, a better entry would be:
>
>     * include/bits/basic_string.tcc (_M_replace_safe):  New function.
>     (_M_replace(input_iterator_tag), append members):  Use it.
>     (_M_replace(forward_iterator_tag)):  Remove.
>     * include/bits/basic_string.h:  Adjust declarations.
>     * src/string-inst.cc:  Adjust declarations.

Thanks Phil. I will use the ChangeLog you suggest. Really, I have to learn how to write
ChangeLog from examples and sometimes I'm quite confused.

Paolo.