[PATCH] libstdc++/5045: wrong numeric_limits::digits10 forinteger types

Nathan Myers ncm-nospam@cantrip.org
Fri Dec 7 17:03:00 GMT 2001


On Sat, Dec 08, 2001 at 01:37:46AM +0100, Paolo Carlini wrote:
> Benjamin Kosnik wrote:
> 
> > > May I apply the following patch?
> > Please wait for Gaby to ok and make a test case please.
> In case Gaby ok the patch this is what I propose for the testsuite.
> +  VERIFY( __glibcpp_s8_digits10 == 2 );
> +  VERIFY( __glibcpp_u8_digits10 == 2 );
> +  VERIFY( __glibcpp_s16_digits10 == 4 );
> +  VERIFY( __glibcpp_u16_digits10 == 4 );
> +  VERIFY( __glibcpp_s32_digits10 == 9 );
> +  VERIFY( __glibcpp_u32_digits10 == 9 );
> +  VERIFY( __glibcpp_s64_digits10 == 18 );

I agree that Paolo's changes are correct, according to the
spirit of LAI-1 that numeric_traits is based on.  I recommend 
we go ahead and commit.

Do we have a u64 == 19 case?

Nathan Myers
ncm at cantrip dot org



More information about the Libstdc++ mailing list