[PATCH] Go closures for s390[x]
Dominik Vogt
vogt@linux.vnet.ibm.com
Mon Dec 22 10:27:00 GMT 2014
On Thu, Dec 18, 2014 at 03:29:01PM -0600, Richard Henderson wrote:
> On 12/16/2014 09:05 AM, Dominik Vogt wrote:
> > lm %r6,%r15,48+24(%r11)
> > + .cfi_remember_state
> > + .cfi_restore 15
> > + .cfi_restore 14
> > + .cfi_restore 13
> > + .cfi_restore 12
> > + .cfi_restore 11
> > + .cfi_restore 10
> > + .cfi_restore 9
> > + .cfi_restore 8
> > + .cfi_restore 7
> > + .cfi_restore 6
> > + .cfi_def_cfa r15, 96
> > br %r4
> > + .cfi_restore_state
>
> I'm not really sure you need any of these restores, since the data is still on
> the stack, unclobbered. I think you'd really only need to reset the cfa here.
I thought about that but left the cif-restores in the code for
documentation purposes. Actually its probably better to remove
them as they cost performance if they get executed.
Sould I make a new patch, or is that something you wanted to post
as part of your cleanup?
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany
More information about the Libffi-discuss
mailing list