[PATCH 2/2] Don't make errlist.o[s].d depend on errlist-compat.h

[Sunil Pandey]

On Thu, May 9, 2024 at 2:22 PM H.J. Lu <hjl.tools@gmail.com> wrote:

> stdio-common/errlist.o.d and stdio-common/errlist.os.d aren't generated
> alongside with stdio-common/errlist-compat.h.  Don't make them depend on
> stdio-common/errlist-compat.h to avoid infinite loop with make-4.4.  This
> fixes BZ #31330.
>
> Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
> ---
>  sysdeps/gnu/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sysdeps/gnu/Makefile b/sysdeps/gnu/Makefile
> index 97fcb6fb90..26dc91d90a 100644
> --- a/sysdeps/gnu/Makefile
> +++ b/sysdeps/gnu/Makefile
> @@ -54,8 +54,7 @@ $(objpfx)errlist-compat.h: $(objpfx)errlist-compat.c
>  generated += errlist-compat.c errlist-compat.h
>
>  # This will force the generation above to happy if need be.
> -$(foreach o,$(object-suffixes) $(object-suffixes:=.d),\
> -         $(objpfx)errlist$o): $(objpfx)errlist-compat.h
> +$(foreach o,$(object-suffixes),$(objpfx)errlist$o):
> $(objpfx)errlist-compat.h
>  endif
>
>  ifeq ($(subdir),login)
> --
> 2.45.0
>
>
LGTM
Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>

--Sunil