[Backport] testsuite: stdlib/isomac.c: add missing include

H.J. Lu hjl.tools@gmail.com
Thu May 9 21:46:48 GMT 2024


On Thu, May 9, 2024 at 2:45 PM Sunil Pandey <skpgkp2@gmail.com> wrote:
>
> I would like to backport following commit to 2.29 and 2.28 branches.  Any comments or objections?
>
> commit 11f382ee780649549428cb25af3a9f1d3465868d
> Author: Aurelien Jarno <aurelien@aurel32.net>
> Date:   Tue Jan 8 21:10:28 2019 +0100
>
>     testsuite: stdlib/isomac.c: add missing include
>
>     When running the testsuite, building stdlib/isomac.c outputs the
>     following warning:
>
>       gcc -O   -D_GNU_SOURCE -DIS_IN_build -include /home/aurel32/glibc-build/config.h isomac.c -o /home/aurel32/glibc-build/stdlib/isomac
>       isomac.c: In function ?get_null_defines?:
>       isomac.c:260:3: warning: implicit declaration of function ?close?; did you mean ?pclose?? [-Wimplicit-function-declaration]
>          close (fd);
>          ^~~~~
>          pclose
>
>     Fix that by adding the <unistd.h> include.
>
>     Changelog:
>             * stdlib/isomac.c: Include <unistd.h>.

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.


-- 
H.J.


More information about the Libc-stable mailing list