[PATCH v3 1/3] x86: Optimize memcmp SSE2 in memcmp.S

[Sunil Pandey]

On Tue, Apr 19, 2022 at 6:21 PM Noah Goldstein via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Tue, Apr 19, 2022 at 5:56 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Tue, Apr 19, 2022 at 3:53 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > On Tue, Apr 19, 2022 at 3:30 PM Joseph Myers <joseph@codesourcery.com> wrote:
> > > >
> > > > A recent commit, probably this one, broke the build for x86_64-linux-gnu
> > > > --disable-multi-arch.
> > > >
> > > > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/x86_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-minimal/glibc/libc_pic.os: in function `internal_fnwmatch':
> > > > /scratch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:513: undefined reference to `__wmemcmp'
> > > > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/x86_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /scratch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:536: undefined reference to `__wmemcmp'
> > > > /scratch/jmyers/glibc-bot/install/compilers/x86_64-linux-gnu/lib/gcc/x86_64-glibc-linux-gnu/11.2.1/../../../../x86_64-glibc-linux-gnu/bin/ld: /scratch/jmyers/glibc-bot/src/glibc/posix/fnmatch_loop.c:704: undefined reference to `__wmemcmp'
> > > >
> > > > https://sourceware.org/pipermail/libc-testresults/2022q2/009576.html
> > >
> > > Reproduced issue, think have fix. Testing it now.
> >
> > Posted a patch.
>
> Pushed fix.
> > > >
> > > > --
> > > > Joseph S. Myers
> > > > joseph@codesourcery.com

I would like to backport this patch to release branches.
Any comments or objections?

Conflict resolution patch attached.

--Sunil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0019-x86-Optimize-memcmp-SSE2-in-memcmp.S.patch
Type: application/octet-stream
Size: 25841 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/libc-stable/attachments/20220512/5f605dd3/attachment-0001.obj>