[PATCH] x86-64: Remove bzero weak alias in SS2 memset

Sunil Pandey skpgkp2@gmail.com
Thu May 12 19:23:02 GMT 2022


On Mon, Feb 14, 2022 at 8:18 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Thu, Feb 10, 2022 at 11:52 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date:   Mon Feb 7 05:55:15 2022 -0800
> >
> >     x86-64: Optimize bzero
> >
> > added the optimized bzero.  Remove bzero weak alias in SS2 memset to
> > avoid undefined __bzero in memset-sse2-unaligned-erms.
> > ---
> >  sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
> > index 329c58ee46..d52d170804 100644
> > --- a/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
> > +++ b/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
> > @@ -31,9 +31,7 @@
> >  # endif
> >
> >  # undef weak_alias
> > -# define weak_alias(original, alias) \
> > -       .weak bzero; bzero = __bzero
> > -
> > +# define weak_alias(original, alias)
> >  # undef strong_alias
> >  # define strong_alias(ignored1, ignored2)
> >  #endif
> > --
> > 2.34.1
> >
>
> I am checking in this patch.
>
> --
> H.J.

I would like to backport this patch to release branches.
Any comments or objections?

--Sunil


More information about the Libc-stable mailing list