[PATCH v4 3/5] x86: Optimize strcmp-avx2.S

Sunil Pandey skpgkp2@gmail.com
Wed May 4 05:40:13 GMT 2022


On Fri, Feb 4, 2022 at 11:14 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Fri, Feb 4, 2022 at 10:57 AM Joseph Myers <joseph@codesourcery.com> wrote:
> >
> > I've seeing a build failure for x32 that looks likely to be caused by this
> > patch.
> >
> > ../sysdeps/x86_64/multiarch/strcmp-avx2.S: Assembler messages:
> > ../sysdeps/x86_64/multiarch/strcmp-avx2.S:109: Error: unsupported instruction `mov'
> > /scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/sysd-rules:847: recipe for target '/scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/string/strncmp-avx2.o' failed
> > make[3]: *** [/scratch/jmyers/glibc-bot/build/glibcs/x86_64-linux-gnu-x32/glibc/string/strncmp-avx2.o] Error 1
> >
>
> Fixed by:
>
> commit 0e0199a9e02ebe42e2b36958964d63f03573c382
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date:   Fri Feb 4 11:11:08 2022 -0800
>
>     x86-64: Fix strcmp-evex.S
>
>     Change "movl %edx, %rdx" to "movl %edx, %edx" in:
>
>     commit 8418eb3ff4b781d31c4ed5dc6c0bd7356bc45db9
>     Author: Noah Goldstein <goldstein.w.n@gmail.com>
>     Date:   Mon Jan 10 15:35:39 2022 -0600
>
>         x86: Optimize strcmp-evex.S
>
> commit c15efd011cea3d8f0494269eb539583215a1feed
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date:   Fri Feb 4 11:09:10 2022 -0800
>
>     x86-64: Fix strcmp-avx2.S
>
>     Change "movl %edx, %rdx" to "movl %edx, %edx" in:
>
>     commit b77b06e0e296f1a2276c27a67e1d44f2cfa38d45
>     Author: Noah Goldstein <goldstein.w.n@gmail.com>
>     Date:   Mon Jan 10 15:35:38 2022 -0600
>
>         x86: Optimize strcmp-avx2.S
>
> --
> H.J.

I would like to backport this patch to release branches.
Any comments or objections?

--Sunil


More information about the Libc-stable mailing list