[PATCH] sunrpc: Remove stray exports without --enable-obsolete-rpc [BZ #23166]

[Florian Weimer]

On 05/11/2018 03:22 PM, Carlos O'Donell wrote:
> On 05/11/2018 08:57 AM, Florian Weimer wrote:
>> This is needed to avoid a warning when linking against libtirpc:
>>
>> /lib64/libc.so.6: warning: common of `rpc_createerr@@TIRPC_0.3.0' overridden by definition
>> /usr/lib64/libtirpc.so: warning: defined here
>>
>> This ld warning is not enabled by default; -Wl,--warn-common enables it.
>>
>> 2018-05-11  Florian Weimer  <fweimer@redhat.com>
>>
>> 	[BZ #23166]
>> 	* include/rpc/clnt.h (rpc_createerr): Declare hidden alias.
>> 	* include/rpc/svc.h (svc_pollfd, svc_max_pollfd, svc_fdset):
>> 	Likewise.
>> 	* sunrpc/rpc_common.c (svc_fdset, rpc_createerr, svc_pollfd)
>> 	(svc_max_pollfd): Add nocommon attribute and hidden alias.  Do not
>> 	export without --enable-obsolete-rpc.
>> 	* sunrpc/svcauth_des.c (svcauthdes_stats): Turn into compatibility
>> 	symbol.  This should not have been exported, ever.
> 
> LGTM.

Thanks.  Do you think we can put this on stable release branches, 2.27 
in particular?

I think anyone building without --enable-obsolete-rpc (not many distros 
do at this point) will really, really want this patch, to avoid linking 
issues with libtirpc.

Thanks,
Florian