[PATCH 2.22] posix: Sync glob with gnulib [BZ #1062]

Tulio Magno Quites Machado Filho tuliom@linux.ibm.com
Mon Jan 1 00:00:00 GMT 2018


Raphael Moreira Zinsly <rzinsly@linux.vnet.ibm.com> writes:

> This patch syncs posix/glob.c implementation with gnulib version
> b5ec983 (glob: simplify symlink detection).  The only difference
> to gnulib code is
>
>   * DT_UNKNOWN, DT_DIR, and DT_LNK definition in the case there
>     were not already defined.  Gnulib code which uses
>     HAVE_STRUCT_DIRENT_D_TYPE will redefine them wrongly because
>     GLIBC does not define HAVE_STRUCT_DIRENT_D_TYPE.  Instead
>     the patch check for each definition instead.
>
> Also, the patch requires additional globfree and globfree64 files
> for compatibility version on some architectures.  Also the code
> simplification leads to not macro simplification (not need for
> NO_GLOB_PATTERN_P anymore).
>
> Checked on x86_64-linux-gnu and on a build using build-many-glibcs.py
> for all major architectures.

LGTM.

With this patch, I could merge the following patches:
[PATCH 2.22 02/14] CVE-2017-15670: glob: Fix one-byte overflow [BZ #22320]
[PATCH 2.22 03/14] glob: Add new test tst-glob-tilde
[PATCH 2.22 05/14] glob: Fix buffer overflow during GLOB_TILDE unescaping [BZ #22332]

If there are any objections, I plan to merge it next Tuesday.

After merging these patches, the following patch would still be pending from
your initial submission:
[PATCH 2.22 11/14] linux: make getcwd(3) fail if it cannot obtain an absolute path [BZ #22679]

Thanks!

-- 
Tulio Magno



More information about the Libc-stable mailing list