[PATCH][BZ #15054] MIPS: Fix syscall wrappers for syscall restart support
Maciej W. Rozycki
macro@codesourcery.com
Thu Jan 24 12:47:00 GMT 2013
On Wed, 23 Jan 2013, Joseph S. Myers wrote:
> > +#ifdef __mips_micromips
> > +#define MOVE32 "move32"
> > +#else
> > +#define MOVE32 "move"
> > +#endif
>
> Indent preprocessor directives inside #if, so "# define", here and in the
> other instances of this code in the patch.
>
> > + register long __s0 asm("$16") __attribute__((unused)) = number; \
>
> Space between __attribute__ and ((unused)), everywhere this construct
> appears in this patch.
Oops, sorry about this oversight -- presumably there needs to be a space
between asm and () as well, right? It looks like we don't respect this
requirement at all right now throughout the files concerned.
> OK with those whitespace fixes; remember to update the list of fixed bugs
> in the NEWS file (a single list is used for both libc and ports bugs) as
> part of your commit of the fix, and to close the bug as fixed afterwards.
I'll do, thanks for the tips.
Maciej
More information about the Libc-ports
mailing list