[Bug localedata/22241] New locale: Yakut (Sakha) locale for Russia (sah_RU)

digitalfreak at lingonborough dot com sourceware-bugzilla@sourceware.org
Thu Jul 12 10:16:00 GMT 2018


https://sourceware.org/bugzilla/show_bug.cgi?id=22241

--- Comment #9 from Rafal Luzynski <digitalfreak at lingonborough dot com> ---
I must say that I'm impressed with the high quality of this patch. However,
here are some nitpicks:

+% ab_alt_mon - The alternative abbreviations for the months
+% - тохс, олун, кул, муус, ыам, бэс, от, атыр, бал, алт, сэт, ахс
+ab_alt_mon  "<U0442><U043E><U0445><U0441>";"<U043E><U043B><U0443><U043D>";/
+            "<U043A><U0443><U043B>";"<U043C><U0443><U0443><U0441>";/
+            "<U044B><U0430><U043C>";"<U0431><U044D><U0441>";/
+            "<U043E><U0442>";"<U0430><U0442><U044B><U0440>";/
+            "<U0431><U0430><U043B>";"<U0430><U043B><U0442>";/
+            "<U0441><U044D><U0442>";"<U0430><U0445><U0441>"
+
+% abmon and ab_alt_mon are actually identical.

There is no need to provide ab_alt_mon if it is identical to abmon. This is not
destructive but so far we have never added ab_alt_mon when it was identical to
abmon (and alt_mon when it was identical to mon). The point is that these
arrays are identical in majority of languages and we don't want to disturb
them.

> +mon         "<U0442><U043E><U0445><U0441><U0443><U043D><U043D><U044C><U0443>";/
> +            "<U043E><U043B><U0443><U043D><U043D><U044C><U0443>";/
> +            "<U043A><U0443><U043B><U0443><U043D><U0020><U0442><U0443><U0442><U0430><U0440>";/

What about using a plain space (" ") instead of "<U0020>"?

> +LC_MESSAGES
> +% The affirmative response -
> +% '^[+1yYдДэЭ]'
> +yesexpr "<U005E><U005B><U002B><U0031><U0079><U0059><U0434><U0414><U044D><U042D><U005D>"
> +
> +% The negative response -
> +% '^[-0nNнНсС]'
> +noexpr "<U005E><U005B><U002D><U0030><U006E><U004E><U043D><U041D><U0441><U0421><U005D>"

Could you please use ASCII characters wherever they are ASCII, that is "^"
instead of "<U005E>" and so on? So it should be:

+yesexpr "^[+1yY<U0434><U0414><U044D><U042D>]"
+noexpr "^[-0nN<U043D><U041D><U0441><U0421>]"

+LC_NAME
+copy "ru_RU"
+END LC_NAME

Good but it could also contain the Sakha translations for "Mr.", "Mrs.", and so
on. However, ru_RU has the same problem. On the other hand, I don't think this
information is actually used by any real application.

> +LC_ADDRESS
> +postal_fmt    "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
> +<U0025><U0064><U0025><U004E><U0025><U0062><U0025><U004E><U0025><U0073>/
> +<U0020><U0025><U0068><U0020><U0025><U0065><U0020><U0025><U0072><U0025>/
> +<U004E><U0025><U0025><U007A><U0020><U0025><U0054><U0025>/
> +<U004E><U0025><U0063><U0025><U004E>"

Same here, ASCII could be used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Libc-locales mailing list