my strstr is broken

Siddhesh Poyarekar siddhesh@gotplt.org
Tue Sep 11 15:38:00 GMT 2018


On Tuesday 11 September 2018 08:51 PM, Paul Pluzhnikov wrote:
> This is the second time in my (short) memory strstr got broken with
> very long inputs
> (https://sourceware.org/bugzilla/show_bug.cgi?id=12092).
> There was also https://sourceware.org/bugzilla/show_bug.cgi?id=14602
> 
> It seems that testing of strstr is entirely inadequate: (AFAICT) we
> only test the IFUNC-selected version, and only on small set of inputs.

I'm not sure about the assertion about not testing IFUNC versions (since 
only x86_64 and powerpc seem to be using them and their IFUNC_IMPL 
macros look correct to me and should trigger all variants provided the 
hardware supports it) but a stress test would be most welcome.

Thanks,
Siddhesh



More information about the Libc-help mailing list