[Patch] RFE new API - gettimezone
Siddhesh Poyarekar
siddhesh.poyarekar@gmail.com
Wed Apr 2 13:52:00 GMT 2014
On 2 April 2014 18:44, P J P <pj.pandit@yahoo.co.in> wrote:
> Hello,
>
> WRT BZ#1077902 [1], please find attached herein, a patch to add the new API - gettimezone(),
> which returns local time zone information in the form of a POSIX TZ environment variable string.
> The API reads the '/etc/localtime' file to fetch the said information.
>
> Could someone please help me with the patch review and other comments that could be helpful for the development of this API.
> --
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1077902#c2
Hey PJP,
Patches go to libc-alpha at sourceware dot org, this mailing list is
for general questions. You might want to take a look at the
contribution checklist:
http://sourceware.org/glibc/wiki/Contribution%20checklist
Also, you might want to post the patch inline rather than as an
attachment since it makes reviews easier.
Finally, I took a quick look at the patch and it looks like more of an
independent program to demo a function rather than something that
actually builds into glibc. There are several other changes you'll
need to change to get there, like:
- Avoid using the hardcoded strings and use those defined in glibc instead
- Modifying time/Makefile to get gettimezone to build.
- Adding a symbol to time/Versions to export a symbol for gettimezone.
Siddhesh
--
http://siddhesh.in
More information about the Libc-help
mailing list