Need help in properly formatting a patch for glibc
Tue Aug 19 12:21:00 GMT 2008
On Tue, Aug 19, 2008 at 4:57 AM, Denys Vlasenko <firstname.lastname@example.org> wrote:
> On Mon, 2008-08-18 at 15:28 -0400, Carlos O'Donell wrote:
>> On Mon, Aug 18, 2008 at 11:42 AM, Ryan Arnold <email@example.com> wrote:
>> > On Mon, Aug 18, 2008 at 10:32 AM, Denys Vlasenko <firstname.lastname@example.org> wrote:
>> >> Please advice what I did wrong, and what is the correct Changelog
>> >> format.
>> Your patch also lacks the following:
>> 1. A detailed explanation of the patch.
>> e.g. Under what conditions does it occur?
> Details are at https://bugzilla.redhat.com/show_bug.cgi?id=457508
It is customary to repeat some of the important details *and* include
Please remember that we are all volunteers. You have to make it easy
for us to give you an "A+" on your bug report and patch.
Adding a summary of the relevant details helps give you an "A+"
>> 2. Testing.
>> e.g. After patching glibc, did you run the testsuite to verify your
>> patch didn't break anything?
> Yes, it does not break anything.
Excellent. It's important that you state something like "No
regressions on $target" where $target is the system on which you ran
the glibc testsuite. This shows the developers that you checked to see
if your patch caused regressions.
More information about the Libc-help