nscd/netlink changes

Roland McGrath roland@hack.frob.com
Mon Oct 31 23:47:00 GMT 2011


You use the header <netlink/netlink.h> but this belongs to the libnl
package, which AFAICT we are not actually using.  It seems better to do:

diff --git a/nscd/connections.c b/nscd/connections.c
index 1b8a9bd..c741996 100644
--- a/nscd/connections.c
+++ b/nscd/connections.c
@@ -34,7 +34,8 @@
 #include <unistd.h>
 #include <arpa/inet.h>
 #ifdef HAVE_NETLINK
-# include <netlink/netlink.h>
+# include <linux/netlink.h>
+# include <linux/rtnetlink.h>
 #endif
 #ifdef HAVE_EPOLL
 # include <sys/epoll.h>


Next, I suspect you had some nscd/Makefile changes that you didn't commit.
The check_pf.c changes seem to suggest that you want to compile that file
separately into nscd rather than using the library version.  But nothing
does that.  This results in nscd not linking because __bump_nl_timestamp
is not an exported function in the library version of the code.


Thanks,
Roland



More information about the Libc-hacker mailing list