[PATCH] PPC fenv fixes.

Richard Henderson rth@twiddle.net
Thu Apr 5 02:27:00 GMT 2007


On Wed, Mar 28, 2007 at 10:44:56AM -0500, Steven Munroe wrote:
>     performance penalty (but have no other visible effect).  */
>  extern const fenv_t *__fe_nomask_env (void);
>  # define FE_NOMASK_ENV	(__fe_nomask_env ())
> +
> +/* Floating-point environment with all exceptions disabled.  */
> +extern const fenv_t *__fe_mask_env (void);
> +# define FE_MASK_ENV	(__fe_mask_env ())

This is incorrect.  The mere evaluation of FE_NOMASK_ENV/FE_MASK_ENV
should have no effect at all.  This stuff should be delayed until
the environment is actually installed.

You should be using magic numbers, like in the i386 port.


r~



More information about the Libc-hacker mailing list