[PATCH] Fixes for make clean (take 2)

Andreas Jaeger aj@suse.de
Sat Jan 8 16:49:00 GMT 2005


Jakub Jelinek <jakub@redhat.com> writes:

> On Fri, Jan 07, 2005 at 02:58:21PM +0100, Andreas Jaeger wrote:
>> > This change is bad:
>> > make[2]: Entering directory
>> > `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/elf' Makefile:726: warning: overriding commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
>> > ../Rules:118: warning: ignoring old commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
>> > mkdir /usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf
>> >
>> > I think putting tst-pie1.out and tst-pie1 into generated instead would cure
>> > this.
>> 
>> I'll revert my patch now,
>
> This seems to work for me:

But why is it necessary?  Why are we using both
tests: $(objpfx)some-test.out
and
tests += other-test

Only the later should be needed AFAIK,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-hacker/attachments/20050108/b5c000c5/attachment.sig>


More information about the Libc-hacker mailing list