[PATCH] Fix dl-load.c typo

Jakub Jelinek jakub@redhat.com
Tue Feb 8 18:03:00 GMT 2005


Hi!

Following typo seems to be the cause of:
Didn't expect signal from child: got `Segmentation fault'
make[2]: *** [/usr/src/libc/objl/elf/tst-tls9.out] Error 1
Didn't expect signal from child: got `Segmentation fault'
make[2]: *** [/usr/src/libc/objl/elf/tst-tls4.out] Error 1
Didn't expect signal from child: got `Segmentation fault'
make[2]: *** [/usr/src/libc/objl/elf/tst-tls5.out] Error 1
Didn't expect signal from child: got `Segmentation fault'
make[2]: *** [/usr/src/libc/objl/elf/tst-tls7.out] Error 1
Didn't expect signal from child: got `Segmentation fault'
Didn't expect signal from child: got `Segmentation fault'
make[2]: *** [/usr/src/libc/objl/elf/tst-tls6.out] Error 1
make[2]: *** [/usr/src/libc/objl/elf/tst-tls8.out] Error 1
in linuxthreads build.
The result is that _dl_tls_setup () is not called although it should.

2005-02-08  Jakub Jelinek  <jakub@redhat.com>

	* elf/dl-load.c (_dl_map_object_from_fd): Fix a typo.

--- libc/elf/dl-load.c.jj	2005-02-08 17:24:04.000000000 +0100
+++ libc/elf/dl-load.c	2005-02-08 18:58:05.584415097 +0100
@@ -1084,7 +1084,7 @@ _dl_map_object_from_fd (const char *name
 	    }
 
 # ifdef SHARED
-	  if (l->l_prev == NULL || (mode && __RTLD_AUDIT) != 0)
+	  if (l->l_prev == NULL || (mode & __RTLD_AUDIT) != 0)
 	    /* We are loading the executable itself when the dynamic linker
 	       was executed directly.  The setup will happen later.  */
 	    break;


	Jakub



More information about the Libc-hacker mailing list