[PATCH] Change INTERNAL_SYSCALL* so that it supports both arches which have error embedded in retval and arches which signal error otherwise

Ulrich Drepper drepper@redhat.com
Mon Jan 6 01:39:00 GMT 2003


Roland McGrath wrote:

> I guess this is ok, but a little bulky.  If it's always `int err' and
> nonzero to indicate, on x86 that's something like "err = retval < 0 ?
> -retval : 0;".  Does the compiler really fail to eliminate all that work if
> `err' is dead?

I don't think it's "bulky" and I definitely don't want to take the
chance that gcc misses to optimize some variable out.

-- 
--------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------



More information about the Libc-hacker mailing list