posix_fadvise change

[Andreas Jaeger]

Jakub Jelinek <jakub@redhat.com> writes:

> On Sat, Aug 16, 2003 at 11:17:45AM +0200, Andreas Jaeger wrote:
>> 
>> You missed at least the following two changes.  I'll commmit them
>> now.  Tested on x86_64-linux-gnu.
>> 
>> Andreas
>> 
>> 2003-08-16  Andreas Jaeger  <aj@suse.de>
>> 
>> 	* sysdeps/generic/posix_fadvise.c (posix_fadvise): Adjust prototype.
>> 	* sysdeps/generic/posix_fadvise64.c (posix_fadvise64): Likewise.
>
> Well, not only that, it should be changed to
>   return ENOSYS;
> instead of
>   __set_errno (ENOSYS);
>   return -1;
> as well.
> Forgot to put that into my patch.

Yeah, you're right.  I'll commit the patch below now,

Andreas

2003-08-16  Jakub Jelinek <jakub@redhat.com>, Andreas Jaeger  <aj@suse.de>

	* sysdeps/generic/posix_fadvise.c (posix_fadvise): Return ENOSYS
	instead of setting errno.
	* sysdeps/generic/posix_fadvise64.c (posix_fadvise64): Likewise.

============================================================
Index: sysdeps/generic/posix_fadvise.c
--- sysdeps/generic/posix_fadvise.c	16 Aug 2003 09:17:57 -0000	1.3
+++ sysdeps/generic/posix_fadvise.c	16 Aug 2003 16:10:10 -0000
@@ -25,8 +25,7 @@
 int
 posix_fadvise (int fd, __off_t offset, __off_t len, int advise)
 {
-  __set_errno (ENOSYS);
-  return -1;
+  return ENOSYS;
 }
 stub_warning (posix_fadvise)
 #include <stub-tag.h>
============================================================
Index: sysdeps/generic/posix_fadvise64.c
--- sysdeps/generic/posix_fadvise64.c	16 Aug 2003 09:17:57 -0000	1.3
+++ sysdeps/generic/posix_fadvise64.c	16 Aug 2003 16:10:10 -0000
@@ -25,8 +25,7 @@
 int
 posix_fadvise64 (int fd, __off64_t offset, __off64_t len, int advise)
 {
-  __set_errno (ENOSYS);
-  return -1;
+  return ENOSYS;
 }
 stub_warning (posix_fadvise64)
 #include <stub-tag.h>

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-hacker/attachments/20030816/50a8de8f/attachment.sig>