test-src in elf/Makefile

[Andreas Schwab]

Roland McGrath <roland@redhat.com> writes:

|> > What is this supposed to fix:
|> > 
|> > 	* elf/Makefile (test-srcs): Add $(modules-names) to it.
|> > 
|> > test-srcs is supposed to only contain targets for binaries, but
|> > modules-names only contains .so targets.
|> 
|> This was the easy way to make sure that cppflags-iterator.mk got used for
|> compiling those modules, which should have -DNOT_IN_libc.  I now notice
|> that test-srcs is used for binaries-bounded, which is not appropriate for
|> these modules, but I am not sure it hurts.

It hurts when compiling with a cross compiler, see the tests target in
Rules:

ifeq ($(cross-compiling),yes)
tests: $(addprefix $(objpfx),$(tests) $(test-srcs))
xtests: tests
else

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."