_IO_wfile_underflow_mmap error/eof case

Ulrich Drepper drepper@redhat.com
Tue Jul 30 14:47:00 GMT 2002


Roland McGrath wrote:
> It seems to me that:
> 
>       fp->_flags |= _IO_EOF_SEEN;
> 
> in _IO_wfile_underflow_mmap is wrong.  In that case,
> _IO_file_underflow_mmap has already set either the EOF or ERROR flag bit.
> If there was an error rather than EOF, the EOF bit should not be set too.
> Am I missing something or should I remove this line?

Might just be a copy&paste thing.  Is it noticeable from user code?  Or 
the other way around: do you have code which stresses this code?

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------



More information about the Libc-hacker mailing list