[ia64-tools] Re: Re: ia64 fenv patch.

[H . J . Lu]

On Fri, Sep 22, 2000 at 11:16:22AM +0200, Jes Sorensen wrote:
> >>>>> "HJ" == H J Lu <hjl@valinux.com> writes:
> 
> HJ> On Thu, Sep 21, 2000 at 10:51:44AM +0200, Andreas Schwab wrote:
> >> What's wrong with this?  Both expressions are equivalent.
> >> 
> 
> HJ> I have so many problems with those functions. I just copied them
> HJ> from ia32 :-(. Also it looks nicer :-).
> 
> There was a reason why I put in most of the type casts in the
> beginning, you have to make sure that the C manipulations do not play
> the default truncate to int size.

If you do it right, it shouldn't be an issue.

> 
> You claim in your patch that the logic was wrong - could you try and
> explain what was actually wrong instead of just saying something was
> wrong? It's somewhat hard to judge a patch if you don't try and tell
> us what it is trying to solve.

Have you tried to fix all those "make check" failures under ia64?


H.J.