[PATCH] resolv/resolv.h fixes

Mark Kettenis kettenis@wins.uva.nl
Tue Jul 25 06:51:00 GMT 2000


   Date: Tue, 25 Jul 2000 15:14:01 +0200
   From: Jakub Jelinek <jakub@redhat.com>

   It is not a warning, it is fatal error in fact:
   /usr/include/resolv.h:95: `res_send_qhook' declared with an exception
   specification

Whatever.

   > However
   > simply removing the __P there isn't exactly the right solution.  These
   > are types for callback functions, so we should remove the __THROW
   > attribute from the resolver functions that might end up calling these
   > such callbacks too.  I'll take responsibility for that.

   Ok.

Forget about it.  If we go with my suggestion we'll have to change too
many things, all the way up to gethostbyname(), and probably compile a
lot o stuff with -fexceptions too.  Let's just declare that throwing
an exception inside those hook functions simply isn't supported.

   > I don't like the __RES_PTHREAD_INTERNAL hack.  We shoudn't clutter the
   > public header files with internal details if possible.  I now realize
   > that I made some changes to the LinuxThreads files that I somehow
   > lost.  I'll submit those shortly.

   Fine if you #undef _res in linuxthreads/internals.h and declare the
   structure.

I was doing that in pthreads.c, since that's the only place in the
LinuxThreads sources where we actually want to reference the global
_res variable.

Mark


More information about the Libc-hacker mailing list