[PATCH] resolv/resolv.h fixes

Mark Kettenis kettenis@wins.uva.nl
Tue Jul 25 06:01:00 GMT 2000


   Date: Tue, 25 Jul 2000 14:16:01 +0200
   From: Jakub Jelinek <jakub@redhat.com>

   Hi!

   Several glibc changes from resolv.h disappeared during update from bind,
   which causes crashes in threaded programs and several C++ programs not to
   compile.

I quite deliberately removed some of the changes that were made.  The __P ->
__THROW changes shouldn't be necessary.  I'd prefer not make that to
stay closer to the BIND sources.  

I'm not sure about the res_send_qhook and res_send_rhook.  The C++
compiler will probably warn about the current situation.  However
simply removing the __P there isn't exactly the right solution.  These
are types for callback functions, so we should remove the __THROW
attribute from the resolver functions that might end up calling these
such callbacks too.  I'll take responsibility for that.

I don't like the __RES_PTHREAD_INTERNAL hack.  We shoudn't clutter the
public header files with internal details if possible.  I now realize
that I made some changes to the LinuxThreads files that I somehow
lost.  I'll submit those shortly.

Mark


More information about the Libc-hacker mailing list