[PATCH 1/2] math: Test libmvec functions with mixed vector lanes
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Fri Nov 13 11:21:15 GMT 2026
On 09/11/26 10:36, Pierre Blanchard wrote:
> Thank you! This looks good to me. Thank you for addressing the issues with the +0.1 in SVE too.
>
> Is TEST_VEC_LOOP used anywhere else, or can it be removed now?
It is only used on x86 sincos wrappers (sysdeps/x86/fpu/test-math-vector-sincos.h).
The generic VECTOR_WRAPPER_fFF in math/test-math-vector.h is not used anywhere,
so I will remove it on a v2 and move TEST_VEC_LOOP and INIT_VEC_LOOP next to the
sincos wrappers.
Removing them completely means running sincos through the lane layouts, which needs
a driver change for the two outputs.
>
> The present checks cover most common cases, for more complete coverage I would suggest (for future improvement or in this series if it’s easy enough):
>
> *
> Add +1/-1 to the list of control values (relevant to logBp1 and inverse hyberbolics)
Done.
> *
> Test the special/control lanes too
Done.
>
>
> Because we are not checking lane match for regular inputs, this is a slightly different test than before, but it is overall an improvement over previous test suite.
>
> —
> Pierre
More information about the Libc-alpha
mailing list