[PATCH 3/3] Rules: Add check for test tunables in *-ENV

Yury Khrustalev yury.khrustalev@arm.com
Fri Nov 6 10:42:20 GMT 2026


Normal tests should use either '*TUNABLES' or '*-TUNABLES-only' for
test-specific tunables.

See commit 5ea36b2cf4a0cbf8995e2ea82bf7485ce627e32a for details.

This check will prevent any such accidental use of -ENV for tunables.
Note that tests with custom recipes for generating .out files and
tests that sent GLIBC_TUNABLES in wrapper scripts or in test code
are not affected. This use case is similar to using '*-TUNABLES-only'.
---
 Rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Rules b/Rules
index b7dc5ff856..3596564bd6 100644
--- a/Rules
+++ b/Rules
@@ -429,6 +429,7 @@ ifneq "$(strip $(tests) $(tests-container) $(tests-internal) $(xtests) $(test-sr
 # These are the implicit rules for making test outputs
 # from the test programs and whatever input files are present.
 define make-test-out
+$(if $(findstring GLIBC_TUNABLES,$($*-ENV)),$(error $*-ENV contains GLIBC_TUNABLES)) \
 $(if $($*-ENV-only),$(test-wrapper-env-only) $($*-ENV-only) $(test-tunables),\
      $(test-wrapper-env) $(run-program-env) $($*-ENV) $(test-tunables)) \
 $(host-test-program-cmd) $($*-ARGS)
-- 
2.47.3



More information about the Libc-alpha mailing list