[PATCH 13/23] linux: Add fchroot
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Thu Nov 5 16:28:37 GMT 2026
On 05/11/26 11:31, Andreas Schwab wrote:
> On Nov 05 2026, Florian Weimer wrote:
>
>> * Adhemerval Zanella:
>>
>>> diff --git a/sysdeps/unix/sysv/linux/bits/unistd_ext.h b/sysdeps/unix/sysv/linux/bits/unistd_ext.h
>>> index a541b378d03..6597435ace7 100644
>>> --- a/sysdeps/unix/sysv/linux/bits/unistd_ext.h
>>> +++ b/sysdeps/unix/sysv/linux/bits/unistd_ext.h
>>> @@ -47,4 +47,10 @@ extern __pid_t gettid (void) __THROW;
>>> # define CLOSE_RANGE_CLOEXEC (1U << 2)
>>> #endif
>>>
>>> +/* Change the root directory of the calling process to the directory
>>> + referred to by the file descriptor FD. FD can also be FD_FAILFS_ROOT,
>>> + in which case all subsequent absolute file name lookups fail. FLAGS
>>> + must be zero. */
>>> +extern int fchroot (int __fd, unsigned int __flags) __THROW;
>>> +
>>> #endif /* __USE_GNU */
>>
>> CRIU defines _GNU_SOURCE, and it has:
>>
>> criu/files.c:#include <unistd.h>
>>
>> criu/files.c:static int fchroot(int fd)
>
> BSD also has fchroot without the flags. Should the one above be called
> fchroot2, or should the flags be dropped for now?
>
This is annoying, but doable. We can add both fchroot as SYS_fchroot with
flags set to 0 and fchroot2 with Linux signature. I don't have a strong
opinion.
More information about the Libc-alpha
mailing list