[PATCH] Makefile: Fix elf/tst-trace tests
Yury Khrustalev
yury.khrustalev@arm.com
Mon Nov 2 11:55:24 GMT 2026
On Thu, Oct 29, 2026 at 04:27:20PM -0300, Adhemerval Zanella Netto wrote:
>
> On 28/10/26 10:35, Yury Khrustalev wrote:
> > The elf/tst-trace tests used
> >
> > ${ ... } $$@; $$(evaluate-test)
> >
> > that ignored any errors inside ${ ... }. These braces seem to be
> > redundant and only mask any issues in the enclosed command.
> > ---
> > elf/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/elf/Makefile b/elf/Makefile
> > index 2c74e11946..71c26ef405 100644
> > --- a/elf/Makefile
> > +++ b/elf/Makefile
> > @@ -3478,11 +3478,11 @@ $(objpfx)tst-trace$(1).out: $(objpfx)libtracemod1/libtracemod1.so \
> > $(objpfx)libtracemod5/libtracemod5.so \
> > $(..)scripts/tst-ld-trace.py \
> > tst-trace$(1).exp
> > - ${ $(PYTHON) $(..)scripts/tst-ld-trace.py \
> > + $(PYTHON) $(..)scripts/tst-ld-trace.py \
> > "$(test-wrapper-env) $(elf-objpfx)$(rtld-installed-name) \
> > --library-path $(common-objpfx):$(strip $(2)) \
> > $(objpfx)libtracemod1/libtracemod1.so" tst-trace$(1).exp \
> > - } > $$@; $$(evaluate-test)
> > + > $$@; $$(evaluate-test)
> > endef
> >
> > $(eval $(call tst-trace-skeleton,1,))
>
> This does not work when 'test-wrapper' is not empty, because scripts/tst-ld-trace.py sets
> LD_TRACE_LOADED_OBJECTS=1 in the subprocess environment. It then runs
> opts.command.split()[1:], which assumes the first word is env.
Yes, we can see that now :)
I will change the patch to address the underlying issue as well.
Thanks,
Yury
More information about the Libc-alpha
mailing list