[PATCH v2 3/3] malloc: Remove currently broken memory tagging

DJ Delorie dj@redhat.com
Wed May 20 18:19:07 GMT 2026


Yury Khrustalev <yury.khrustalev@arm.com> writes:
> DJ, could you clarify what is the problem here?

The patch didn't apply for me either.

Your patch has this:

-static __always_inline void *
-tag_at (void *ptr)
-{
-  return ptr;
-}
-
 
 /*
   MORECORE-related declarations. By default, rely on sbrk

but the git source had this:

static __always_inline void *
tag_at (void *ptr)
{
  if (__glibc_unlikely (mtag_enabled))
    return __libc_mtag_address_get_tag (ptr);
  return ptr;
}

#include <string.h>

/*
  MORECORE-related declarations. By default, rely on sbrk

Note the extra #include, which you just removed.  After I updated my
sources just now the patch applied.

Note that the trybot uses "git am" to apply patches.  I had varying lock
with "git apply" and "patch", even after updating my source tree.



More information about the Libc-alpha mailing list