[PATCH] Fix hurd bootstrap after 4c6f92daead
Paul Eggert
eggert@cs.ucla.edu
Tue May 19 15:34:21 GMT 2026
On 2026-05-19 07:54, Adhemerval Zanella wrote:
> #if HAVE_GETTEXT
> -# define _(msgid) gettext(msgid)
> +# ifndef _
> +# define _(msgid) gettext(msgid)
> +# endif
> #else /* !HAVE_GETTEXT */
> # define _(msgid) (msgid)
> #endif /* !HAVE_GETTEXT */
> -#define N_(msgid) (msgid)
> +#ifndef N_
> +# define N_(msgid) (msgid)
> +#endif
Why is this part of the patch is needed? Don't the macro definitions in
timezone/private.h exactly match those in include/libintl.h, which means
the timezone code is valid even without this patch?
If this part is needed, I suggest adding a comment saying why. Also we
should propagate this part upstream if it's needed (I can arrange for
the propagation).
More information about the Libc-alpha
mailing list