[PATCH] stdbit: Fix builtin name used in __glibc_has_builtin check for rotate_right

Uros Bizjak ubizjak@gmail.com
Wed May 6 13:27:13 GMT 2026


On Wed, May 6, 2026 at 2:03 PM Adhemerval Zanella Netto
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 06/05/26 08:03, Uros Bizjak wrote:
> > The __glibc_has_builtin check in include/stdbit.h incorrectly refers to
> > ___builtin_stdc_rotate_right (with three leading underscores) instead of the
> > correct __builtin_stdc_rotate_right (two leading underscores). As a result,
> > the builtin is not detected even when supported by the compiler.
> >
> > Fix the spelling to use __builtin_stdc_rotate_right consistently in both the
> > feature test and the corresponding comment.
> >
> > Fixes: 4adae8550a7a ("stdlib: Add internal stdc_rotate_right implementation")
> > Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> > Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Sure enough, I somehow missed the fact that _ull version is missing.
Fixed by the following emergency one-liner patch.

Uros.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-stdlib-add-missing-stdc_rotate_right_ull-alias-when-.patch
Type: text/x-patch
Size: 1602 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20260506/f04c5e98/attachment.bin>


More information about the Libc-alpha mailing list