[PATCH v4 1/2] stdlib: Add internal stdc_rotate_right implementation

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Tue Mar 31 20:10:40 GMT 2026



On 31/03/26 17:07, Joseph Myers wrote:
> On Tue, 31 Mar 2026, Adhemerval Zanella Netto wrote:
> 
>> On 31/03/26 15:26, Joseph Myers wrote:
>>> On Tue, 31 Mar 2026, Adhemerval Zanella wrote:
>>>
>>>> It follows the C2y N3367 proposed interface, along with some tests
>>>> imported from gnulib (and adapted to glibc libsupport).
>>>>
>>>> Checked on x86_64-linux-gnu and i686-linux-gnu.
>>>> ---
>>>>  include/stdbit.h               |  68 +++++
>>>
>>> It seems odd to put this in the internal header rather than the installed 
>>> header (conditional on __GLIBC_USE (ISOC2Y)) and corresponding public 
>>> ABIs.
>>>
>>
>> Because the idea of this patch is to make it easier to integrate the
>> gnulib code, which aim to use its std_rotate_right instead of its old
>> bitrotate.h; and I do not want to commit to full C2y N3367 implementation
>> now.
> 
> I think it would be reasonable to add the rotate operations separately 
> from the endian-aware load/store operations, even though they were added 
> to C2y at the same time.
> 

Could we work to make it a subsequent patch? I will add on my backlog to
a proper stdc_rotate_right and stdc_rotate_left.  I will like to focus
on fts issues first.


More information about the Libc-alpha mailing list