[PATCH v2 10/23] nscd: Use uint8_t instead of bitfield in struct hashentry

Carlos O'Donell carlos@redhat.com
Tue Mar 24 17:53:36 GMT 2026


On 3/20/26 4:42 PM, Florian Weimer wrote:
> This enables access through <concurrent_buffer.h>

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>   nscd/nscd-client.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/nscd/nscd-client.h b/nscd/nscd-client.h
> index dd7421c5d1..c507933acb 100644
> --- a/nscd/nscd-client.h
> +++ b/nscd/nscd-client.h
> @@ -283,7 +283,7 @@ datahead_init_neg (struct datahead *head, nscd_ssize_t allocsize,
>   /* Structure for one hash table entry.  */
>   struct hashentry
>   {
> -  request_type type:8;		/* Which type of dataset.  */
> +  uint8_t type;			/* Type of dataset; see request_type.  */
>     bool first;			/* True if this was the original key.  */
>     nscd_ssize_t len;		/* Length of key.  */
>     ref_t key;			/* Pointer to key.  */


-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list