[PATCH v3 6/8] math: Consolidated common definition/data for cosh/sinh/tanh

[Adhemerval Zanella Netto]

On 13/03/26 20:45, DJ Delorie wrote:
> 
> LGTM other than one comment.
> Reviewed-by: DJ Delorie <dj@redhat.com>
> 
> Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
>> diff --git a/sysdeps/ieee754/dbl-64/e_cosh_data.c b/sysdeps/ieee754/dbl-64/e_cosh_data.c
>> +/* Data definitions used by cosh implementation.
>> diff --git a/sysdeps/ieee754/dbl-64/e_coshsinh_data.c b/sysdeps/ieee754/dbl-64/e_coshsinh_data.c
>> +/* Data definitions used by cosh and sinh implementation.
>> diff --git a/sysdeps/ieee754/dbl-64/e_sinh_data.c b/sysdeps/ieee754/dbl-64/e_sinh_data.c
>> +/* Correctly rounded hyperbolic sine for binary64 values.
> 
> ^^ This one's comment is inconsistent with the others (.c vs .h)

Ack, I will fix it before installing it.

> 
>> diff --git a/sysdeps/ieee754/dbl-64/e_tanh_data.c b/sysdeps/ieee754/dbl-64/e_tanh_data.c
>> +/* Data definitions used by tanh implementation.
> 
>> diff --git a/sysdeps/ieee754/dbl-64/e_cosh_data.h b/sysdeps/ieee754/dbl-64/e_cosh_data.h
>> +/* Correctly rounded hyperbolic cosine for binary64 values.
>> diff --git a/sysdeps/ieee754/dbl-64/e_coshsinh_data.h b/sysdeps/ieee754/dbl-64/e_coshsinh_data.h
>> +/* Correctly rounded hyperbolic sine for binary64 values.
>> diff --git a/sysdeps/ieee754/dbl-64/e_sinh_data.h b/sysdeps/ieee754/dbl-64/e_sinh_data.h
>> +/* Correctly rounded hyperbolic sine for binary64 values.
>> diff --git a/sysdeps/ieee754/dbl-64/e_tanh_data.h b/sysdeps/ieee754/dbl-64/e_tanh_data.h
>> +/* Correctly rounded hyperbolic tangent function for binary64 values.
>