Fw:[PATCH] inet: add boundary check to prevent bof and inet/tst-ruserpass [BZ #33881]

[Arjun Shankar]

Hey! Sorry I didn't get to this earlier.

> I managed to troubleshoot the problem recreating the ci environment using the ci code by Dj.

Great!

> I didn't catch it immediately because on my local system it was not crashing. Why not? I don't knwo. Maybe due to the fact that I'm on a 64 bit x86_64 system, while dj one is 32 bit?

For future reference, testing 32-bit Intel on a 64-bit Intel system is
easy to manage (without installing the CICD tool) by simply using this
configure line, which forces the rest of the build to target 32-bit
mode:
> ${glibc_srcdir}/configure CC="gcc -m32" CXX="g++ -m32" --prefix=/usr --build=i686-pc-linux-gnu --host=i686-pc-linux-gnu
(I copied this directly from DJ's CICD repo)
You will need 32-bit development packages. Anyway, configuring for 32
bit and then running "make && make check" will show you any testsuite
failures on 32-bit Intel.

> Could I submit a new patch?

Yes, please do. Ideally, with a v2 in the subject line like this:
[PATCH v2] inet: add boundary check to prevent bof and
inet/tst-ruserpass [BZ #33881]

Makes it easy to know which patch is being superceded, and I think our
patchwork tooling picks it up as well.

> I'm gonna write a little blog article, to explain how to setup locally this environment.
>
> I will provide also scripts to automate the job to make it simple for people to debug in a common environment.

Thank you. Please also consider looking at the glibc wiki to see
what's missing, and contributing there as well:
https://sourceware.org/glibc/wiki/HomePage
A lot of the information there is scattered and while it contains
details, it sometimes lacks flow. e.g. it would be nice to have a
beginner focused section on getting started with some step by step
instructions on one page.

Thank you for your submission. Looking forward to the v2!