[PATCH v2] Break out ldconfig parser
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Wed Mar 11 14:13:51 GMT 2026
On 11/03/26 10:24, Yury Khrustalev wrote:
> On Thu, Feb 26, 2026 at 09:49:04PM -0500, DJ Delorie wrote:
>>
>> Florian Weimer <fweimer@redhat.com> writes:
>>> I think we should start giving the ldconfig files ldconfig- or similar
>>> prefixes, so that things appear a bit less crowded in the elf directory.
>>
>> Renamed.
>>
>>> Do we need a separate parseconf.h file, or could we stick it into an
>>> existing shared header?
>>
>> I moved it to ldconfig.h, which for some reason is in sysdeps...
>>
>>> And I think the function comment should be a bit more elaborate.
>>
>> Documented. I also cleaned up the API a bit.
>>
>> elf: factor out ld.conf parsing
>
> Thanks for this, sorry I'm late with my comments and I see Adhemerval
> has already added RB, but I have a few more questions.
>
> I agree with Adhemerval that ldconfig_parse_config should be marked as hidden.
The main problem is currently attribute_hidden is only defined for
#if defined SHARED || defined LIBC_NONSHARED \
|| (BUILD_PIE_DEFAULT && IS_IN (libc))
which would require some refactoring to add this on ldconfig and other
installed binaries. That's why I think it would be a different patch.
More information about the Libc-alpha
mailing list