[PATCH v2] Break out ldconfig parser

Andreas Schwab schwab@suse.de
Wed Mar 4 09:18:43 GMT 2026


On Mär 03 2026, DJ Delorie wrote:

> Andreas Schwab <schwab@suse.de> writes:
>>> +/* Declared in ldconfig-parse.c */
>>> +typedef void (ldconfig_parse_config_cb) (const char *line,
>>
>> The parens are redundant.
>
> Perhaps, but it helps make it more obvious that it's not a function
> declaration,

No, that's what typedef does.  The extra parens only add confusion, it
looks as if someone forgot to add an asterisk.  And the misleading
comment only adds to the confusion.

> It's also consistent with existing practice:

Nope, none of those are relevant.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


More information about the Libc-alpha mailing list