[PATCH v8 1/5] Add system-wide tunables: ldconfig part

[DJ Delorie]

Arjun Shankar <arjun@redhat.com> writes:
> Should be "overridable" and "nonoverridable" to match the commit
> message and manual.

Fixed :-P

>> +  if (id == -1)
>> +    printf("%s:%d: Warning: tunable %s not recognized.\n",
>> +          filename, lineno, name);
>
> Now we warn for unrecognized tunables.
> Style issue with missing space before "(".

Fixed.

>> +  else
>> +    {
>> +      entry->value_is_negative = 0;
>> +      if (sscanf (value, "%lld", &entry->value_ull) == 1)
>> +       entry->value_was_parsed = 1;
>> +    }
>
> So value_is_negative and value_was_parsed being read now.
> The unsigned value should be scanned with "%llu".

Fixed.