[PATCH v2 2/8] resolv: Declare __p_class_syms, __p_type_syms for internal use

[Carlos O'Donell]

On 6/16/26 12:31 PM, Florian Weimer wrote:
> ---
>   include/resolv.h   | 5 +++++
>   resolv/res_debug.c | 4 ----
>   2 files changed, 5 insertions(+), 4 deletions(-)

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> 
> diff --git a/include/resolv.h b/include/resolv.h
> index 4dbbac3800..d5ad9994b9 100644
> --- a/include/resolv.h
> +++ b/include/resolv.h
> @@ -70,6 +70,11 @@ libc_hidden_proto (__libc_res_nameinquery)
>   extern __typeof (__res_queriesmatch) __libc_res_queriesmatch;
>   libc_hidden_proto (__libc_res_queriesmatch)
>   
> +extern const struct res_sym __p_class_syms[];
> +libresolv_hidden_proto (__p_class_syms)
> +extern const struct res_sym __p_type_syms[];
> +libresolv_hidden_proto (__p_type_syms)

OK.

> +
>   /* Variant of res_hnok which operates on binary (but uncompressed) names.  */
>   bool __res_binary_hnok (const unsigned char *dn) attribute_hidden;
>   
> diff --git a/resolv/res_debug.c b/resolv/res_debug.c
> index 73af0c72fe..6bf9962916 100644
> --- a/resolv/res_debug.c
> +++ b/resolv/res_debug.c
> @@ -390,8 +390,6 @@ p_fqname(const u_char *cp, const u_char *msg, FILE *file) {
>    * that C_ANY is a qclass but not a class.  (You can ask for records of class
>    * C_ANY, but you can't have any records of that class in the database.)
>    */
> -extern const struct res_sym __p_class_syms[];
> -libresolv_hidden_proto (__p_class_syms)
>   const struct res_sym __p_class_syms[] = {
>     {C_IN,    (char *) "IN"},
>     {C_CHAOS, (char *) "CHAOS"},
> @@ -426,8 +424,6 @@ const struct res_sym __p_update_section_syms[] attribute_hidden = {
>    * Names of RR types and qtypes.  The list is incomplete because its
>    * size is part of the ABI.
>    */
> -extern const struct res_sym __p_type_syms[];
> -libresolv_hidden_proto (__p_type_syms)
>   const struct res_sym __p_type_syms[] = {
>     {ns_t_a,      (char *) "A",     (char *) "address"},
>     {ns_t_ns,     (char *) "NS",    (char *) "name server"},


-- 
Cheers,
Carlos.