[PATCH v2 4/8] resolv: Improve formatting of unknown records in ns_sprintrrf

[Adhemerval Zanella Netto]

On 16/06/26 13:31, Florian Weimer wrote:
> Do not add the "unknown RR type" comment.  After adding the TYPE
> prefix, the number is largely redundant.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  resolv/ns_print.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/resolv/ns_print.c b/resolv/ns_print.c
> index e75c39eaa8..3d38876483 100644
> --- a/resolv/ns_print.c
> +++ b/resolv/ns_print.c
> @@ -115,7 +115,6 @@ ns_sprintrrf(const u_char *msg, size_t msglen,
>  
>  	const char *comment;
>  	char tmp[100];
> -	char errbuf[40];
>  	int len, x;
>  
>  	/*
> @@ -590,20 +589,18 @@ ns_sprintrrf(const u_char *msg, size_t msglen,
>  		T(addstr(tmp, len, &buf, &buflen));
>  		break;
>  	    }
> -
>  	default:
> -		snprintf (errbuf, sizeof (errbuf), "unknown RR type %d", type);
> -		comment = errbuf;
> +		comment = "";
>  		goto hexify;
>  	}
>  	return (buf - obuf);
>   formerr:
> -	comment = "RR format error";
> +	comment = " ; RR format error";
>   hexify: {
>  	int n, m;
>  	char *p;
>  
> -	len = SPRINTF((tmp, "\\# %u%s\t; %s", (unsigned)(edata - rdata),
> +	len = SPRINTF((tmp, "\\# %u%s%s", (unsigned)(edata - rdata),
>  		       rdlen != 0U ? " (" : "", comment));
>  	T(addstr(tmp, len, &buf, &buflen));
>  	while (rdata < edata) {