[PATCH] io: fix ftw ABI on MIPS n64

Xi Ruoyao xry111@xry111.site
Tue Jul 21 18:07:15 GMT 2026


On Wed, 2026-07-22 at 01:27 +0800, Xi Ruoyao wrote:
> On MIPS n64 off_t is same as off64_t, but struct stat is not same as
> struct stat64 (very peculiar but see the "as tempting as it..."
> comment
> in linux/mips/kernel_stat.h).  As the ftw/ftw64 callback accepts a
> pointer to a function who accepts struct stat/stat64, for MIPS n64 we
> must use different implementations for ftw and ftw64.
> 
> Thus for testing if ftw64 can be aliased to ftw, we should check
> XSTAT_IS_XSTAT64 instead of __OFF_T_MATCHES_OFF64_T.
> 
> This resolves the io/tst-ftw-lnk failure observed on MIPS n64.
> 
> Link: https://sourceware.org/glibc/wiki/Testing/Tests/io/tst-ftw-lnk
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
> 
> Tested on x86_64-linux and mips64-linux.

Sorry, this is incorrect as it duplicates ftw and ftw64 on x86_64 (the
test suite didn't catch the issue).  I'm revising the patch.  Please
disregard this version.

-- 
Xi Ruoyao <xry111@xry111.site>


More information about the Libc-alpha mailing list